fix: Add fix to fracture state in case of high cohesion#3964
Open
npillardou wants to merge 5 commits intodevelopfrom
Open
fix: Add fix to fracture state in case of high cohesion#3964npillardou wants to merge 5 commits intodevelopfrom
npillardou wants to merge 5 commits intodevelopfrom
Conversation
npillardou
requested review from
castelletto1,
jhuang2601 and
rrsettgast
as code owners
npillardou
changed the title
npillardou
changed the title
jhuang2601
added
type: bug
castelletto1
added
ci: run CUDA builds
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3964 +/- ##
===========================================
- Coverage 58.87% 58.87% -0.01%
===========================================
Files 1353 1353
Lines 112953 112964 +11
===========================================
- Hits 66504 66502 -2
- Misses 46449 46462 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jhuang2601
reviewed
Feb 6, 2026
| if( currentTau > limitTau ) | ||
| { | ||
| // Tangential traction exceeds cohesion limit: transition to slip | ||
| LvArray::tensorOps::fill< 3 >( localTractionNew, 0.0 ); |
Contributor
There was a problem hiding this comment.
@castelletto1 @jafranc
If fields::contact::FractureState::Slip, why zero out localTractionNew?
For open element, it is correct; but for the slipped ones, I guess the normal traction (localTractionNew[0]) should be preserved?
Contributor
Author
There was a problem hiding this comment.
I think you're right, I kept it the same as before, but logically the traction should remain the same, if not zero.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to correct a condition found in the ALM method.
The implementation is based from the LM method ( physicsSolvers/solidMechanics/contact/SolidMechanicsLagrangeContact.cpp:2274-2335) :
Some tests have been performed showing a better consistency in Aramis case with very high cohesion (1e20):
Previous implementation:
With the fix:
